feat: introduce module coordinator #47
Conversation
diehbria
force-pushed
the
coord-refact
branch
2 times, most recently
from
e23633f
to
65cee36
Compare
diehbria
force-pushed
the
coord-refact
branch
2 times, most recently
from
b0def83
to
5b019de
Compare
NorbertNader
requested review from
NorbertNader
and removed request for
gareth-amazon
| update: (subscriptionUpdate: SubscriptionUpdate<SiteWiseDataStreamQuery>) => void; | ||
| }; | ||
| iotsitewise: { | ||
| subscribeToAssetTree: (query: SiteWiseAssetTreeQuery, callback: SiteWiseAssetTreeCallback) => AssetTreeSubscription; |
There was a problem hiding this comment.
I think this is going to be refactored again. But the intention is not to require a Query to get a Session.
Maybe I should get rid of the "Query" language here and move this over to subscribe/promise methods like the core module.
There was a problem hiding this comment.
yup, this is definitely incremental, I'm going to hand off that portion to @boweihan to finish off :-)
| import { DescribeAssetModelResponse } from '@aws-sdk/client-iotsitewise'; | ||
| import { completeDataStreams } from '../../completeDataStreams'; | ||
|
|
||
| export const subscribeToTimeSeriesData = |
There was a problem hiding this comment.
To my mind, this is the definition of a Query implementation. We will just make this produce a Provider<> in the refactor.
| export * from './iotsitewise/time-series-data/types.d'; | ||
|
|
||
| export type IoTAppKitSession = { | ||
| subscribeToTimeSeriesData: ( |
There was a problem hiding this comment.
As Gareth has pointed out, we'll be changing this class to only handle registering data modules and metrics. This is good incremental progress towards that!
|
|
||
| if (input.registerDataSources !== false) { | ||
| /** Automatically registered data sources */ | ||
| dataModule.registerDataSource(createDataSource(siteWiseSdk)); |
There was a problem hiding this comment.
Next step, support initializing with multiple data modules that each have their own credential schemes :)
|
|
||
| const { update, unsubscribe } = dataModule.subscribeToDataStreams({ queries, request }, (updatedDataStreams) => { | ||
| dataStreams = updatedDataStreams; | ||
| emit(); |
There was a problem hiding this comment.
data and asset requests are fired and emitted independently here. Would it be a better chart experience to guarantee simultaneous initial data delivery?
There was a problem hiding this comment.
the end goal is to make it configurable on how this behavior is. consider this PR as part one. There's a couple things missing, that is one of them.
* fix aggregated data parsing * remove unused styles in core * mark deprecated mocks as deprecated within core * move mock data source into testing * refactor the data source into source specific folders * add some tests in asset session
diehbria
dismissed stale reviews from boweihan, NorbertNader, fpauer, and gareth-amazon
via
ffb5567
diehbria
force-pushed
the
coord-refact
branch
from
5b019de
to
ffb5567
Compare
…G files (#47) Co-authored-by: Mitchell Lee <mitchlee@amazon.com>
* fix aggregated data parsing * remove unused styles in core * mark deprecated mocks as deprecated within core * move mock data source into testing * refactor the data source into source specific folders * add some tests in asset session
Overview
subscribeToDataStreamtosubscribeToTimeSeriesDatadatamocks.spec.tstomocks.tsas it wasn't actually a test file. later we will move this to the testing sub folderParts contributed by @fpauer
Legal
This project is available under the Apache 2.0 License.