Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use viewport from provider #515

Merged
merged 1 commit into from
Jan 25, 2023
Merged

fix: use viewport from provider #515

merged 1 commit into from
Jan 25, 2023

Conversation

NorbertNader
Copy link
Contributor

@NorbertNader NorbertNader commented Jan 25, 2023

Overview

Fixes #143

  • use viewport from provider instead of props, this was overriding actual viewport when interacting with chart

  • use latest @synchro-charts/core with fix for live mode (do not emit dateRangeChange if not interacting with chart)

Legal

This project is available under the Apache 2.0 License.

@NorbertNader NorbertNader changed the title fix: use viewport from provider #143 fix: use viewport from provider Jan 25, 2023
Copy link
Contributor

@jmbuss jmbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not using the prop, should we remove it and the watcher for it?

@jmbuss jmbuss self-requested a review January 25, 2023 16:52
@NorbertNader
Copy link
Contributor Author

We still need the viewport, just don’t pass it directly to the synchro-charts components. Instead they are passed down from the provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viewport skitter bug
2 participants