feat(dashboard): initial scaffolding for input widget #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorbertNader
requested review from
square-li,
tjuranek,
mpopv,
corteggiano,
diehbria and
jmbuss
NorbertNader
force-pushed
the
input-widget
branch
8 times, most recently
from
49a90aa
to
2a5d4c7
Compare
NorbertNader
force-pushed
the
input-widget
branch
from
2a5d4c7
to
d830067
Compare
jmbuss
reviewed
Feb 13, 2023
| @@ -0,0 +1,5 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const InputComponent: React.FC = () => <div>input</div>; | |||
There was a problem hiding this comment.
Something to note / not required, you could copy and paste the text icon and just change the T to an I
There was a problem hiding this comment.
I like that idea! Let me run it by UX. Thanks.
NorbertNader
commented
Feb 13, 2023
| @@ -30,6 +31,8 @@ export const widgetCreator = | |||
| return appKitWidgetCreator(componentTag as AppKitComponentTag, preset); | |||
| } else if (componentTag === 'text') { | |||
| return textWidgetCreator(componentTag, preset); | |||
| } else if (componentTag === 'input') { | |||
There was a problem hiding this comment.
I'm worried this part is not scalable. Noticed we have conditions for text widget in multiple places and I just followed this pattern for now. I want to tackle this at some point.
jmbuss
approved these changes
Feb 13, 2023
Closed
This was referenced Mar 4, 2023
Closed
Merged
Merged
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
initial scaffolding for input widget
Legal
This project is available under the Apache 2.0 License.