feat: create react-components and source-iotsitewise pkgs #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehbria
force-pushed
the
pkgs
branch
2 times, most recently
from
df2ca08
to
3e634b5
Compare
diehbria
force-pushed
the
pkgs
branch
11 times, most recently
from
4d13e90
to
9a16634
Compare
* move core build files away from stencil config into package.json to prepare moving away from stencil to build core * fix various typing issues in iot-app-kit * remove unused code * remove unecessary `AssetQuery` type, which collides with other types * make test runner fail if uncommited changes present
NorbertNader
approved these changes
Feb 16, 2022
boweihan
reviewed
Feb 16, 2022
| ], | ||
| plugins: [typescript({ tsconfig: './tsconfig.json' })], | ||
| }, | ||
| { |
| @@ -3,7 +3,7 @@ import { sitewiseSdk } from './iotsitewise/time-series-data/sitewise-sdk'; | |||
| import { SiteWiseAssetDataSource } from './data-module/types'; | |||
| import { createSiteWiseAssetDataSource } from './iotsitewise/time-series-data/asset-data-source'; | |||
| import { SiteWiseAssetModule } from './asset-modules'; | |||
| import { IoTAppKitInitInputs, IoTAppKitComponentSession } from './interface.d'; | |||
| import { IoTAppKitInitInputs, IoTAppKitComponentSession } from './index'; | |||
| @@ -1015,4 +1021,6 @@ it('requests buffered data', async () => { | |||
| propertyId: query.assets[0].properties[0].propertyId, | |||
| }) | |||
| ); | |||
|
|
|||
| unsubscribe(); | |||
| "description": "React specific wrapper for IoT Application Kit", | ||
| "author": { | ||
| "name": "Amazon Web Services", | ||
| "url": "https://aws.amazon.com/" |
There was a problem hiding this comment.
Is this standard? Should we be linking to AWS or can we link to SiteWise?
There was a problem hiding this comment.
grabbed this from other repos
| @@ -0,0 +1,106 @@ | |||
| import React, { createElement } from 'react'; | |||
There was a problem hiding this comment.
Can we leave a comment to the source at the top of file so it's clear we didn't write it? I assume we pulled this from somewhere like https://github.com/ionic-team/stencil-ds-output-targets/blob/main/packages/react-output-target/react-component-lib/createComponent.tsx.
| @@ -0,0 +1,142 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Same comment wrt. documentation for this file
| @@ -0,0 +1,114 @@ | |||
| import { camelToDashCase } from './case'; | |||
sheilaXu
pushed a commit
that referenced
this pull request
Sep 23, 2022
…lign with UX (#57) Co-authored-by: Mitchell Lee <mitchlee@amazon.com>
TheEvilDev
pushed a commit
that referenced
this pull request
Nov 2, 2022
* move core build files away from stencil config into package.json to prepare moving away from stencil to build core * fix various typing issues in iot-app-kit * remove unused code * remove unecessary `AssetQuery` type, which collides with other types * make test runner fail if uncommited changes present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
prepare moving away from stencil to build core
AssetQuerytype, which collides with other types.Legal
This project is available under the Apache 2.0 License.