feat: add support for aggregated data for sitewise data source #6
Conversation
| import { DataStreamCallback } from '../../../data-module/types'; | ||
| import { isDefined } from '../../../common/predicates'; | ||
|
|
||
| const getAggregatedPropertyDataPointsForProperty = ({ |
There was a problem hiding this comment.
why not to use async/await for this function too ?
There was a problem hiding this comment.
we don't have to since getAggregatedPropertyDataPointsForProperty returns a promise and getAggregatedPropertyDataPoints resolves the promise with Promise.all
| @@ -58,3 +58,38 @@ export const toDataPoint = (assetPropertyValue: AssetPropertyValue | undefined): | |||
| y: dataValue, | |||
| }; | |||
| }; | |||
|
|
|||
| // TODO: support outputting multiple sets of DataStream for multiple aggregate types. | |||
| const aggregateToValue = ({ average, count, maximum, minimum, sum }: Aggregates): number => { | |||
There was a problem hiding this comment.
I dont see Aggregates being imported on this file ? eslint did not flag this ?
There was a problem hiding this comment.
Thanks for catching this, yeah looks like I also missed AggregatedValue
There was a problem hiding this comment.
There's some work to be done on the build system, I don't think it'll fail yarn build from eslint. For now run yarn fix to check for any errors
NorbertNader
force-pushed
the
sitewise-aggreagted-data
branch
from
8936536
to
a2a2a70
Compare
| @@ -58,3 +58,38 @@ export const toDataPoint = (assetPropertyValue: AssetPropertyValue | undefined): | |||
| y: dataValue, | |||
| }; | |||
| }; | |||
|
|
|||
| // TODO: support outputting multiple sets of DataStream for multiple aggregate types. | |||
| const aggregateToValue = ({ average, count, maximum, minimum, sum }: Aggregates): number => { | |||
There was a problem hiding this comment.
There's some work to be done on the build system, I don't think it'll fail yarn build from eslint. For now run yarn fix to check for any errors
| expect(onError).toBeCalled(); | ||
| }); | ||
|
|
||
| it('returns data point on success', async () => { |
There was a problem hiding this comment.
wed'll need to add some pagination tests - though missing them on the other paginated data calls as well, fine as a follow up item
Co-authored-by: Norbert Nader <nnader@amazon.com>
Issue #, if available:
Description of changes:
add support for aggregated data for sitewise data source
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.