feat: import queries directly from source-iotsitewise #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boweihan
commented
Feb 18, 2022
| "pack": "yarn pack" | ||
| }, | ||
| "dependencies": { | ||
| "@iot-app-kit/core": "0.0.1", |
There was a problem hiding this comment.
These aren't used at the moment but are the core deps that will be needed once we move sitewise specific files in here.
boweihan
force-pushed
the
source-iotsitewise-alias
branch
2 times, most recently
from
db49f6c
to
eaf9b2b
Compare
boweihan
force-pushed
the
source-iotsitewise-alias
branch
from
eaf9b2b
to
8b31961
Compare
| @@ -0,0 +1,3 @@ | |||
| import { query, datamodule } from '@iot-app-kit/core'; | |||
|
|
|||
| export { query, datamodule }; | |||
There was a problem hiding this comment.
could you move the query namespace file? seems like if something isn't moved this could go backwards.
gareth-amazon
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Export and use
querymethods for sitewise directly from thesource-iotsitewisemodule. Set up a build system forsource-iotsitewise.This is effectively a passthrough export at the moment because fully decoupling sitewise from the app kit core turned out to be a much larger task.
Tests
https://github.com/boweihan/iot-app-kit/actions/runs/1866382245
Legal
This project is available under the Apache 2.0 License.