Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, source-iotsitewise, source-iottwinmaker)!: toQueryString on query #634

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

diehbria
Copy link
Contributor

@diehbria diehbria commented Mar 3, 2023

Overview

Adds toQueryString method on queries which enables IoT App Kit components to determine if a query has changed on re-render, or if only the reference to the query has been updated. The motivation of this is to make a more performant useTimeSeriesData hook.

  • Adds toQueryString method to the Query interface
  • Implements toQueryString method on iotsitewise queries
  • Implements toQueryString method on iottwinmaker queries
  • Update documentation regarding how to create a custom data source

BREAKING CHANGES:

  • Adds new required method toQueryString(): string on Query type.

Legal

This project is available under the Apache 2.0 License.

@diehbria diehbria force-pushed the to-string branch 2 times, most recently from 62692b3 to 4eef47c Compare March 3, 2023 19:27
@diehbria diehbria changed the title feat!(core, source-iotsitewise, source-iottwinmaker): toString on query feat(core, source-iotsitewise, source-iottwinmaker)!: toQueryString on query Mar 3, 2023
@diehbria diehbria force-pushed the to-string branch 7 times, most recently from d64c871 to 33ffa2b Compare March 4, 2023 00:24
jmbuss
jmbuss previously approved these changes Mar 4, 2023
…!: Add toQueryString method on Query type, implement in iotsitewise and iottwinmaker

* Utilize toQueryString in useTimeSeriesData to prevent unsubscribe/resubscribes from equivalent queries
@diehbria diehbria mentioned this pull request Mar 4, 2023
@diehbria diehbria merged commit 38a4b98 into main Mar 4, 2023
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
@diehbria diehbria deleted the to-string branch March 16, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants