Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

fix gpu detection #255

Merged
merged 1 commit into from
Jan 3, 2020
Merged

fix gpu detection #255

merged 1 commit into from
Jan 3, 2020

Conversation

roywei
Copy link

@roywei roywei commented Jan 2, 2020

Summary

From MXNet 1.5, the detection of number of GPUs changed from using command linenvidia-smi to MXNet C API call using CUDA.

As a result, keras-mxnet should catch both CalledProcessError and MXNetError

Related Issues

PR Overview

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n]

@sandeep-krishnamurthy
Copy link

When will this error be thrown?

@roywei
Copy link
Author

roywei commented Jan 2, 2020

When will this error be thrown?

@sandeep-krishnamurthy when GPU driver not installed or driver version and cuda version mismatch.

We used CalledProcessError to catch nvidia-smi failure before, but now the error type changed to MXNetError in MXNet 1.5

@roywei roywei merged commit 555eb48 into awslabs:master Jan 3, 2020
@roywei roywei deleted the fix_gpu branch January 29, 2020 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants