Adds sleep after creation and teardown #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds sleep after eks cluster creation because its observed that sometimes dns propagation for the created cluster takes lil bit of time, and after teardown of the eks components to ensure that all the vpc resources are released and ready to be deleted before we start deleting the VPC stack. Signed-off-by: Ashish Ranjan <rnshis@amazon.com>
| @@ -57,7 +57,8 @@ spec: | |||
| if [ "$CREATED_CLUSTER" == "" ]; then | |||
| aws eks create-cluster --name $(params.cluster-name) --region $(params.region) --kubernetes-version $(params.kubernetes-version) --role-arn $SERVICE_ROLE_ARN --resources-vpc-config subnetIds=$subnets,securityGroupIds=$sg $ENDPOINT_FLAG | |||
| fi | |||
| aws eks $ENDPOINT_FLAG --region $(params.region) wait cluster-active --name $(params.cluster-name) | |||
| aws eks $ENDPOINT_FLAG --region $(params.region) wait cluster-active --name $(params.cluster-name) | |||
| sleep 300 | |||
There was a problem hiding this comment.
Line 60 wait cluster-active wouldn't ensure cluster is active already ?
| @@ -38,6 +38,7 @@ spec: | |||
| aws eks wait nodegroup-deleted --nodegroup-name $i --cluster-name $(params.cluster-name) $ENDPOINT_FLAG --region $(params.region); | |||
| done; | |||
| aws eks delete-cluster --name $(params.cluster-name) --region $(params.region) $ENDPOINT_FLAG | |||
| sleep 900 | |||
There was a problem hiding this comment.
This is a lot of time like 15mins ? Do we really need this ? can we see if we have an option of wait until etc through aws eks cli to ensure it's deleted instead of waiting arbitrarily ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds sleep after eks cluster creation because its observed that sometimes dns propagation for the created cluster takes lil bit of time, and after teardown of the eks components to ensure that all the vpc resources are released and ready to be deleted before we start deleting the VPC stack.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.