Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard duty S3 protection doesnt honour manifest settings #12

Closed
5 tasks done
deepend-dev opened this issue Sep 14, 2022 · 2 comments
Closed
5 tasks done

Guard duty S3 protection doesnt honour manifest settings #12

deepend-dev opened this issue Sep 14, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@deepend-dev
Copy link

deepend-dev commented Sep 14, 2022

Describe the bug
S3 protection gets enabled on guard duty for all account irrespective of settings are disabled on manifest

To Reproduce

  1. Disable s3protection on guardduty on manifest
    image

  2. It is still comes up as enabled
    image

Expected behavior
S3 protection should be disabled

Please complete the following information about the solution:

  • [ x ] Version: [e.g. v1.1.0]

To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SO0021) - Video On Demand workflow with AWS Step Functions, MediaConvert, MediaPackage, S3, CloudFront and DynamoDB. Version v5.0.0". If the description does not contain the version information, you can look at the mappings section of the template:

guardduty:
    enable: true
    excludeRegions: []
    s3Protection:
      enable: false
      excludeRegions: []
    exportConfiguration:
      enable: true
      destinationType: S3
      exportFrequency: FIFTEEN_MINUTES
  • Region: ap-south-1
  • Was the solution modified from the version published on this repository? No
  • If the answer to the previous question was yes, are the changes available on GitHub? No
  • Have you checked your service quotas for the sevices this solution uses?
  • Were there any errors in the CloudWatch Logs?

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

Additional context
Add any other context about the problem here.

@deepend-dev deepend-dev added the bug Something isn't working label Sep 14, 2022
@crissupb
Copy link
Contributor

Yes, this feature is not working as expected in the 1.1.0 release. A fix is currently in the release pipeline.

@nagmesh
Copy link
Contributor

nagmesh commented Oct 13, 2022

In v1.2.0 release, a fix was released for this issue.
In commit, enableS3Protection was referenced from input config and propagated to lambda function which enables the S3 protection.
Thank you for letting us know.
Have a great day!

@nagmesh nagmesh closed this as completed Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants