Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(cicd): Change to config repo does not trigger the AWSAccelerator-Pipeline #35

Closed
6 tasks done
flochaz opened this issue Jan 3, 2023 · 1 comment
Closed
6 tasks done
Labels
bug Something isn't working

Comments

@flochaz
Copy link

flochaz commented Jan 3, 2023

Describe the bug
For any change to be deploy after a commit pushed to the aws-accelerator-config codecommit repo I have to click on "Release Change" in console for them to be applied.

To Reproduce
Push updates to the config repo. Nothing will happen in pipeline

Expected behavior
Automatic trigger of AWSAccelerator-Pipeline on aws-accelerator-config codecommit repo commits.

Please complete the following information about the solution:

  • Version: v1.3.0

  • Region: eu-west-1

  • Was the solution modified from the version published on this repository? No

  • If the answer to the previous question was yes, are the changes available on GitHub? -

  • Have you checked your service quotas for the sevices this solution uses? Yes

  • Were there any errors in the CloudWatch Logs? No

@flochaz flochaz added the bug Something isn't working label Jan 3, 2023
@rycerrat
Copy link
Contributor

rycerrat commented Jan 5, 2023

Hi @flochaz!

Hope you're doing well.

Thank you for submitting an issue for the LZA. At the moment this is the desired configuration, as many customers prefer to make several, small changes to their configuration repo before triggering the pipeline. Due to the broad permission set which the LZA pipeline has to modify any and all resources across an AWS Organization, the triggering of the pipeline should be a deliberate action.

I think there is a valid argument to make a configurable parameter to automatically trigger the pipeline after new commits, however that may not outweigh the risk of customers unintentionally triggering their LZA pipeline and deploying undesired changes.

If you would like to enable this behavior, you can manually update the Code Pipeline in the AWS Code Pipeline console by doing the following:

  • Go to the Accelerator Pipeline (not installer).
  • Edit the Pipeline
  • Edit the Source stage of the Pipeline
  • For the Configuration Action Group, point to the proper Code Commit Repo/branch and select 'Done'

I have also included a link to the documentation here:
https://docs.aws.amazon.com/codepipeline/latest/userguide/update-change-detection.html

Since this is currently our intended behavior, I'll go ahead and resolve this issue. Please reach out if you have any further questions or concerns.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants