Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags are not created in some resources when the global tags are enabled #415

Open
xp-versent opened this issue Mar 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@xp-versent
Copy link

Is your feature request related to a problem? Please describe.
We defined tags [] in the global-config.yaml file as
tags:

  • key: "bus:cost-centre"
    value: "12345"
  • key: "bus:application-name"
    value: "xyz-aws-lza"
  • key: "bus:owner"
    value: "tech-services-ops"
  • key: "ops:env"
    value: "prod"
    We expected these tags will be applied to all resources that LZA created.
    However, we found that all subnets created from the network-config.yaml file, there are no tags.
    Also, all vpc endpoints and dns resolver endpoints do not have tags.
    We have raised the AWS support case "Case ID 170790047001507"
    Describe the feature you'd like
    when defined the central tags in global-config.yaml, we expected all resources created should have those tags defined in the global-config.yaml, except those resources created by the customised CF stacks.
    Additional context
    Add any other context or screenshots about the feature request here.
    We are aware that there is a issue in AWS::EC2::VPCEndpoint - ExistingAttribute-NewProperty - Tag Property for Resource  aws-cloudformation/cloudformation-coverage-roadmap#830 about the endpoint tags. As there are cost associated these endpoints, tags on these resources are impotent for enterprise user.
@xp-versent xp-versent added the enhancement New feature or request label Mar 7, 2024
@richardkeit
Copy link

AWS Team - this is a bug and not an enhancement based on the definition in GlobalConfigTags:

Custom Tags for all resources created by Landing Zone Accelerator that can be tagged.

Describe the bug
Using the global tags, not all resources that support tags are tagged with specified values

To Reproduce
Example config:
global-config:

tags:
- key: "bus:cost-centre"
  value: "12345"
- key: "bus:application-name"
  value: "xyz-aws-lza"

Expected behavior
All resources

  • Version: v1.6.1 [e.g. v1.5.1]
  • Region: ap-southeast-2
  • Was the solution modified from the version published on this repository?
  • If the answer to the previous question was yes, are the changes available on GitHub?
  • Have you checked your service quotas for the services this solution uses?
  • Were there any errors in the CloudWatch Logs?

@bo1984
Copy link

bo1984 commented May 1, 2024

Hello, we have an open bug report for the VPC Endpoints and Subnets not applying the global tags. So you're aware, the DNS resolver endpoints have an exception to not apply the tags as you can see that logic here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants