CustomizationsStack not deploying after 1.5.2

[vanja-zecevic]

Describe the bug
After upgrading to 1.5.2 we have found CustomizationsStack does not deploy.

To Reproduce

1. Run LZA pipeline.
2. Observe AWSAccelerator-CustomizationsStack-* in CloudFormation and notice it has not updated.

Note: Previously the stack would deploy on each run of the pipeline even if there were no changes. We have also run a test where we add a new serviceCatalogPortfolios and a new cloudFormationStackSets in customizations-config.yaml and it still doesn't update.

Expected behavior
AWSAccelerator-CustomizationsStack should update.

Please complete the following information about the solution:

• Version: 1.5.2
• Region: ap-southeast-2
• Was the solution modified from the version published on this repository? No
• Have you checked your service quotas for the services this solution uses? No
• Were there any errors in the CloudWatch Logs? No

Additional context
We have found that the CustomizationsStack is created during synth but it does not deploy.

The problem seems to have been introduced into 1.5.2 by this commit (ee8af64).

The problem is in the deployStacks function. My understanding is that this function would previously deploy all stacks in the cdk app. Now, when the stage is customizations, it only deploys stacks in a list returned by getCustomizationsStackRunOrder which in turn gets the list of stacks from getCustomStacks() which has code below,
public getCustomStacks(): CloudFormationStackConfig[] { return this.customizations?.cloudFormationStacks ?? []; }
This means that only stacks created for entries in cloudFormationStacks in customizations-config.yaml are deployed. The CusomizationsStack itself which contains serviceCatalogPortfolios and cloudFormationStackSets is not in this list and hence is not deployed.

[erwaxler]

Hello, thank you for your interest in the Landing Zone Accelerator! I can confirm this bug existed in v1.5.2, but has been resolved in v1.6.0 with this commit.

I'll be resolving this issue since the bug has been fixed in a newer release, thank you for bringing this to our attention and please continue to create issues for any unexpected behavior.