ManagedAD ActiveDirectoryConfigurationInstanceConfig

[teddevaal]

Describe the bug
The ManagedAD ActiveDirectoryConfigurationInstanceConfig configuration is tightly coupled with the configuration in aws-directory-service construct. Therefore the solution only works if the userdata contains specific functions that the aws-directory-service construct is expecting (e.g. New-AWSQuickStartResourceSignal).

To Reproduce

   activeDirectoryConfigurationInstance:
     instanceType: t3.large
     vpcName: MyVpc
     subnetName: subnet
     imagePath: /aws/service/ami-windows-latest/Windows_Server-2016-English-Full-Base
     securityGroupInboundSources:
       - 10.0.0.0/16
     instanceRole: EC2-Default-SSM-AD-Role
     enableTerminationProtection: false
     userDataScripts: []

Expected behavior
When the AD Configuration Instance is created, I expect the instance to provision successfully regardless of what user data scripts are provided. I also expect the cfn-init logs to be accessible in CloudWatch to make debugging easier.

Please complete the following information about the solution:

• [-] Version: [e.g. v1.6.1]
• [-] Region: [e.g. ap-southeast-2]
• Was the solution modified from the version published on this repository?
• If the answer to the previous question was yes, are the changes available on GitHub?
• [-] Have you checked your service quotas for the services this solution uses?
• Were there any errors in the CloudWatch Logs?

Screenshots
cfn-init log on the windows machine

[richardkeit]

@teddevaal - please add the pipeline failing into the Github issue