Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As of LZA v 1.7.0 having a forward slash in OU name now breaks LZA with an error #472

Open
5 tasks
anthony-sarkis-pwc opened this issue Jun 6, 2024 · 1 comment
Labels
bug Something isn't working response requested

Comments

@anthony-sarkis-pwc
Copy link

Describe the bug
If you have a / in an OU name LZA will error out in the pipeline, this is the error you will receive

2024-06-05 02:27:22.906 \| error \| runner \| Parent organizational unit "CI" not found for organizational unit "CI/CD" in AWS Organizations. -- 174 | Error: Parent organizational unit "CI" not found for organizational unit "CI/CD" in AWS Organizations. 175 | at AWSOrganization.manageOuCreation (/codebuild/output/src1517/src/s3/00/source/packages/@aws-accelerator/modules/lib/aws-organization/index.ts:337:17) 176 | at processTicksAndRejections (node:internal/process/task_queues:95:5) 177 | at async AWSOrganization.handler (/codebuild/output/src1517/src/s3/00/source/packages/@aws-accelerator/modules/lib/aws-organization/index.ts:200:7) 178 | at async main (/codebuild/output/src1517/src/s3/00/source/packages/@aws-accelerator/modules/bin/runner.ts:73:10) 179 | at async /codebuild/output/src1517/src/s3/00/source/packages/@aws-accelerator/modules/bin/runner.ts:81:20 { 180 | level: 'error', 181 | mainLabel: 'accelerator', 182 | [Symbol(level)]: 'error' 183 | } 184 | error Command failed with exit code 1. 185 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

To Reproduce
Add a / in an OU and be sure to include it in the organization-config.yaml file and run it on LZA v 1.7.0, previous versions work fine

Expected behavior
In previous LZA versions there was no issues, now it is erroring out stating it cannot find the OU.

Please complete the following information about the solution:

  • Version: v1.7.0
  • Region: us-east-1
  • Was the solution modified from the version published on this repository? No
  • Have you checked your service quotas for the services this solution uses? Yes
  • Were there any errors in the CloudWatch Logs? Yes

Screenshots
Attached

Additional context
This has worked in every version of LZA, only v1.7.0 has this become an issue

@anthony-sarkis-pwc anthony-sarkis-pwc added the bug Something isn't working label Jun 6, 2024
@crissupb
Copy link
Contributor

Please ensure that you also have the "CI" OU defined separately in the config file along with "CI/CD". The error indicates that it may be missing. The "CD" OU is a child of the "CI" OU when there are slashes in the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working response requested
Projects
None yet
Development

No branches or pull requests

3 participants