Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow actions to be run for forked PRs #131

Closed
wants to merge 1 commit into from

Conversation

truestory1
Copy link
Contributor

Description of changes:
according to https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#adding-permissions-settings
this change should fix https://github.com/awslabs/mountpoint-s3-csi-driver/actions/runs/7616759109/job/20745254205?pr=123

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@truestory1 truestory1 marked this pull request as draft January 31, 2024 11:26
jjkr
jjkr previously approved these changes Feb 13, 2024
@jjkr jjkr dismissed their stale review February 13, 2024 14:30

PR is still marked WIP

@truestory1
Copy link
Contributor Author

according to https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token "Maximum access for pull requests from public forked repositories" is read. I would close this PR. Due to security model seems it's not possible to implement this change.

@truestory1 truestory1 closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants