Fetch nodeID from ENV #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladem
force-pushed
the
remove-metadata-service
branch
from
f4e6766
to
34824ea
Compare
vladem
had a problem deploying
to
PR Unit Tests
GitHub Actions
Failure
vladem
temporarily deployed
to
PR Integration Tests
GitHub Actions
Inactive
vladem
force-pushed
the
remove-metadata-service
branch
from
34824ea
to
5d77f8a
Compare
vladem
temporarily deployed
to
PR Integration Tests
GitHub Actions
Inactive
vladem
force-pushed
the
remove-metadata-service
branch
from
5d77f8a
to
bab31fd
Compare
vladem
force-pushed
the
remove-metadata-service
branch
from
bab31fd
to
3767099
Compare
dlakhaws
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: by fetching nodeID from env we're making driver able to run in absence of EC2Metadata service (e.g. via EKS addon or non-EC2 instances)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.