Promote images on release #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlakhaws
reviewed
Oct 30, 2023
| concurrency: e2e-cluster | ||
| env: | ||
| AWS_REGION : "us-east-1" | ||
| KUBECONFIG: "/tmp/kubeconfig" | ||
| COMMIT_ID: ${{ github.event_name == 'push' && github.sha || github.event.pull_request.head.sha }} | ||
| TMP_IMAGE_NAME: "s3-csi-driver-tmp" |
There was a problem hiding this comment.
do we need a private ecr repo that's named this?
There was a problem hiding this comment.
hmm, tmp here signifies that images will be removed from it (retention is set for 7 days), or what do you mean?
There was a problem hiding this comment.
ahh I thought this was repo name, image name makes sense
|
does this change the documentation that we have in our release pipeline runbook at all? |
dlakhaws
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adjust actions to match the release process (runbook):
<TEST_ECR>/s3-csi-driver:<COMMIT_HASH>TODOs:
release.yaml: replace private ECR with public;release.yaml: push to ARS source repo as well;e2e-tests.yaml: promote images fromv*branches (for old release fixes)Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.