Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding content for public helm repo #31

Closed
wants to merge 1 commit into from
Closed

Conversation

dlakhaws
Copy link
Contributor

@dlakhaws dlakhaws commented Nov 6, 2023

Description of changes:

  • Adding content for public helm repo
  • Will test after this is merged by doing
helm repo add aws-s3-csi-driver https://awslabs.github.io/mountpoint-s3-csi-driver
  • if this works, will add these steps to release runbook:
Package the new release for helm: `helm package charts/aws-s3-csi-driver`
Update the index.yaml: `helm repo index --url https://github.com/awslabs/mountpoint-s3-csi-driver .`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is checking in this tarball temporary to test out your changes? I'd imagine we'd want to pull any artifacts from CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my research, the tarball is necessary for public helm repos, the other drivers don't need to do it because they are in the kubernetes-sigs group that seems to do something behind the scenes on packaging the drivers

@dlakhaws dlakhaws closed this Nov 6, 2023
@dlakhaws dlakhaws deleted the public-helm-repo branch November 6, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants