Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced support for the AWS_ENDPOINT_URL environment variable #895

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

arsh
Copy link
Contributor

@arsh arsh commented May 31, 2024

Description of change

We have introduced support for the AWS_ENDPOINT_URL environment variable. The endpoint determination now follows this order:

  • Use the CLI parameter endpoint-url if provided.
  • Use AWS_ENDPOINT_URL if provided.
  • Fallback to existing behavior

Relevant issues: #890

Does this change impact existing behavior?

Yes, this change can impact existing behavior. Specifically, when the AWS_ENDPOINT_URL environment variable is set and no endpoint parameter is provided via --endpoint-url, the system will now use the AWS_ENDPOINT_URL. This provides an additional method for specifying the endpoint, which could affect how endpoints are resolved in certain configurations.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@arsh arsh had a problem deploying to PR integration tests May 31, 2024 13:13 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests May 31, 2024 13:13 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests May 31, 2024 13:13 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests May 31, 2024 13:13 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests May 31, 2024 13:13 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests May 31, 2024 13:13 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests May 31, 2024 13:13 — with GitHub Actions Failure
@arsh arsh changed the title Aws endpoint url Introduced support for the AWS_ENDPOINT_URL environment variable May 31, 2024
@arsh arsh temporarily deployed to PR integration tests May 31, 2024 14:31 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests May 31, 2024 14:31 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests May 31, 2024 14:31 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests May 31, 2024 14:31 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests May 31, 2024 14:31 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests May 31, 2024 14:31 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests May 31, 2024 14:31 — with GitHub Actions Inactive
@arsh arsh requested a review from dannycjones May 31, 2024 15:18
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I have one comment that we need to handle an additional error case on URI parsing. Others are just minor test updates such as indentation, which I'm not sure why rust-fmt didn't flag.

mountpoint-s3-client/src/s3_crt_client.rs Outdated Show resolved Hide resolved
mountpoint-s3-client/src/s3_crt_client.rs Outdated Show resolved Hide resolved
mountpoint-s3-client/src/s3_crt_client.rs Outdated Show resolved Hide resolved
mountpoint-s3-client/src/s3_crt_client.rs Outdated Show resolved Hide resolved
mountpoint-s3-client/src/s3_crt_client.rs Outdated Show resolved Hide resolved
mountpoint-s3-client/CHANGELOG.md Outdated Show resolved Hide resolved
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 11:52 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 11:52 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 11:52 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 11:52 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 11:52 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 11:52 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 11:52 — with GitHub Actions Failure
@arsh arsh requested a review from dannycjones June 4, 2024 12:02
@dannycjones dannycjones temporarily deployed to PR integration tests June 4, 2024 13:09 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests June 4, 2024 13:09 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests June 4, 2024 13:09 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests June 4, 2024 13:09 — with GitHub Actions Inactive
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 15:28 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 15:28 — with GitHub Actions Failure
@arsh arsh had a problem deploying to PR integration tests June 4, 2024 15:28 — with GitHub Actions Failure
arsh added 4 commits June 5, 2024 08:11
Signed-off-by: Andres Santana <hernaa@amazon.com>
Signed-off-by: Andres Santana <hernaa@amazon.com>
Signed-off-by: Andres Santana <hernaa@amazon.com>
Signed-off-by: Andres Santana <hernaa@amazon.com>
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:18 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:18 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:18 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:18 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:18 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:18 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:18 — with GitHub Actions Inactive
@arsh arsh requested a review from dannycjones June 5, 2024 08:19
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannycjones dannycjones disabled auto-merge June 5, 2024 08:28
2303bd8

Signed-off-by: Andres Santana <hernaa@amazon.com>
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:32 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:32 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:32 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:32 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:32 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:32 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests June 5, 2024 08:32 — with GitHub Actions Inactive
@arsh arsh merged commit 93ac1b0 into main Jun 5, 2024
22 checks passed
@arsh arsh deleted the aws-endpoint-url branch June 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants