-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced support for the AWS_ENDPOINT_URL environment variable #895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I have one comment that we need to handle an additional error case on URI parsing. Others are just minor test updates such as indentation, which I'm not sure why rust-fmt
didn't flag.
Signed-off-by: Andres Santana <hernaa@amazon.com>
Signed-off-by: Andres Santana <hernaa@amazon.com>
Signed-off-by: Andres Santana <hernaa@amazon.com>
Signed-off-by: Andres Santana <hernaa@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2303bd8 Signed-off-by: Andres Santana <hernaa@amazon.com>
Description of change
We have introduced support for the
AWS_ENDPOINT_URL
environment variable. The endpoint determination now follows this order:endpoint-url
if provided.AWS_ENDPOINT_URL
if provided.Relevant issues: #890
Does this change impact existing behavior?
Yes, this change can impact existing behavior. Specifically, when the
AWS_ENDPOINT_URL
environment variable is set and no endpoint parameter is provided via--endpoint-url
, the system will now use theAWS_ENDPOINT_URL
. This provides an additional method for specifying the endpoint, which could affect how endpoints are resolved in certain configurations.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).