Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling virtual-hosted-style addressing #208

Open
DamienMatias opened this issue Jun 3, 2024 · 4 comments
Open

Allow disabling virtual-hosted-style addressing #208

DamienMatias opened this issue Jun 3, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@DamienMatias
Copy link

DamienMatias commented Jun 3, 2024

Tell us more about this new feature.

Hello,

I was wondering if there was a way to force the usage of path style requests instead of the default virtual-hosted-style addressing ?
This is actually possible with mountpoint-s3 as you can see here in their documentation.

To disable virtual-hosted-style addressing, use the --force-path-style command-line flag to instead send requests to https://example.com/docexamplebucket/.

This would allow us using the LakeFS S3 Gateway and potentially other usages that leverage tools still built around the path style addressing.

Thank you 🙏

@DamienMatias DamienMatias added the enhancement New feature or request label Jun 3, 2024
@fuatbasik
Copy link
Contributor

Hello, @DamienMatias !
Thank you for your interest in Amazon S3 Connector for PyTorch. We'll discuss this internally report back here when we have something concrete to share.

@N-o-Z
Copy link

N-o-Z commented Jun 21, 2024

@DamienMatias Hi - lakeFS maintainer here 👋🏽
As a WA for this issue you can configure LAKEFS_GATEWAYS_S3_DOMAIN_NAME to enable lakeFS to work with a virtual host

@devel4848
Copy link

I'am also interested in disabling virtual-hosted-style addressing. I would like to use S3 Connector for PyTorch with a S3-compatible Ceph storage that can not be configured for virtual-hosted-style addressing because of the DNS implication. Only path-style addressing can be used in our context.

@jamesbornholt
Copy link
Member

The S3 client we use supports disabling virtual-hosted-style addressing here, so I think this would just be a matter of plumbing through a new flag from the various constructors (S3IterableDataset.from_prefix and friends) to the Rust constructor here, similar to #195. I'm not sure we're going to get to this in the short term, but we'd happily review a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants