Allow usage of unsigned S3 client #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
previously approved these changes
Mar 27, 2024
Update S3ClientConfig to pass in the configuration for allowing unsigned requests.
dnanuti
force-pushed
the
feature/allow-unsigned-client
branch
from
a9ac828
to
5e5efd2
Compare
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
doc/DEVELOPMENT.md
Outdated
| @@ -150,6 +150,9 @@ Using S3ClientConfig you can set up the following parameters for the underlying | |||
| (max number of parts per upload is 10,000, minimum upload part size is 5 MiB). | |||
| Part size must have **values between 5MiB and 5GiB.** Is set by default to **8MiB** (may change in future). | |||
|
|
|||
| * `unsigned(bool)`: Allows the usage of unsigned clients when accessing public datasets or when other mechanisms are | |||
There was a problem hiding this comment.
nit:
Suggested change
| * `unsigned(bool)`: Allows the usage of unsigned clients when accessing public datasets or when other mechanisms are | |
| * `unsigned(bool)`: Set to true to disable signing S3 requests. |
(we don't want to suggest "other mechanisms" unless you're really, really sure)
doc/DEVELOPMENT.md
Outdated
| @@ -165,6 +168,9 @@ s3_map_dataset = S3MapDataset.from_prefix(DATASET_URI, region=REGION, s3client_c | |||
| s3_checkpoint = S3Checkpoint(region=REGION, s3client_config=config) | |||
| # Works similarly for Lightning checkpoints. | |||
| s3_lightning_checkpoint = S3LightningCheckpoint(region=REGION, s3client_config=config) | |||
|
|
|||
| # Use an unsigned S3 client | |||
There was a problem hiding this comment.
Suggested change
| # Use an unsigned S3 client | |
| # Disable signing to make requests without AWS credentials |
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
approved these changes
Mar 28, 2024
IsaevIlya
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update S3ClientConfig to pass in the configuration for allowing unsigned requests.
Description
We no longer require credentials for accessing public data / data accessible through other mechanisms when using an unsigned client.
Additional context
Related items
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.