Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP docs #16
WIP docs #16
Changes from 19 commits
e68b964
98411f4
aa4381c
0c82bf6
cc0e6b9
2cece86
84b9e27
bc5f4f1
ead9e6d
e29fa6f
a4a1d4e
aa7c7c3
a380445
25baa59
ba1998c
b8fa902
45be1ab
fca73b8
3e98c04
0aebf28
ed9b6db
e0fedd0
2bd0816
2d6c046
59e0c7d
566e4c5
9442165
e2b4372
7b1a414
d0562b6
d0ce252
a3b9d1d
ab86c46
9c4f730
f9a45bd
0a509c7
6e90b23
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also reduction computation happens on training job can slow down the process. this should be considered if total size of tensors sizes are large. (Tensors_Saved_size is proportional to tensor_size , num_steps_saved, num_tensors_saved) .Saved_Tensors_size can be controlled by either tweaking save_config or using reduction