Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide private methods by renaming them to start with _ #2

Merged
merged 7 commits into from
Nov 19, 2019
Merged

Hide private methods by renaming them to start with _ #2

merged 7 commits into from
Nov 19, 2019

Commits on Nov 19, 2019

  1. Rename private methods to start with _, Add register_block, register_… 

    …module methods
    @rahul003
    rahul003 committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    7194ede View commit details
    Browse the repository at this point in the history

  2. Deliberately make some tests use register_hook so we test for that fu… 

    …nctionality not breaking
    @rahul003
    rahul003 committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    c91fd3b View commit details
    Browse the repository at this point in the history

  3. Comment why register_hook remains

    @rahul003
    rahul003 committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    ff8977b View commit details
    Browse the repository at this point in the history

  4. Undo changes in examples

    @rahul003
    rahul003 committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    9e79c34 View commit details
    Browse the repository at this point in the history

  5. Fix test

    @rahul003
    rahul003 committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    b0ff67d View commit details
    Browse the repository at this point in the history

  6. undo change for pytorch

    @rahul003
    rahul003 committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    1ba6f82 View commit details
    Browse the repository at this point in the history

  7. Rename log params for pt

    @rahul003
    rahul003 committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    6b538a8 View commit details
    Browse the repository at this point in the history