-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do-Not-Merge] Ignore sagemaker-uploading #470
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
===========================================
- Coverage 65.53% 50.00% -15.53%
===========================================
Files 173 163 -10
Lines 13280 12934 -346
===========================================
- Hits 8703 6468 -2235
- Misses 4577 6466 +1889
Continue to review full report at Codecov.
|
@@ -1 +1 @@ | |||
__version__ = "1.0.8" | |||
__version__ = "1.0.8b" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
@@ -33,6 +33,7 @@ def _get_checkpoint_files_in_dir(self, cp_dir): | |||
file != METADATA_FILENAME | |||
and file != METADATA_FILENAME_S3_UPLOADED | |||
and "sagemaker-uploaded" not in file | |||
and "sagemaker-uploading" not in file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This won't scale well. Can we keep track of a list of files not to append and then do something like:
if all([metadata_file not in file for metadata_file in metadata_files])
Description of changes:
Style and formatting:
I have run
pre-commit install
to ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.