Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Skip logging the input tensors to the loss block. (#64)" #87

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Revert "Skip logging the input tensors to the loss block. (#64)" #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions smdebug/mxnet/hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,8 @@ def forward_hook(self, block, inputs, outputs):
# This overwhelms the logs; turn back on if you really need it
# logger.debug("Processing the global step {0} for block {1}".format(self.step, block_name))

# Output input tensor if it is not a loss block
if isinstance(block, mx.gluon.loss.Loss) is False:
self._write_inputs(block_name, inputs)
# Output input tensor
self._write_inputs(block_name, inputs)

# Output output tensors
self._write_outputs(block_name, outputs)
Expand Down
3 changes: 0 additions & 3 deletions tests/mxnet/test_hook_loss_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ def test_loss_collection_default():
loss_val = loss_tensor.value(step_num=1)
assert len(loss_val) > 0

# Assert that we are not logging the inputs to loss block.
input_loss_tensors = tr.tensor_names(regex=".*loss._input*")
assert len(input_loss_tensors) == 0
shutil.rmtree(out_dir)


Expand Down