Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added details found needed while onboarding #593

Merged
merged 2 commits into from Jul 22, 2021

Conversation

maghirardelli
Copy link
Contributor

Issue #, if available:

Description of changes: Added clarifying details to the end-to-end testing tutorial and the configuration of machine images for workspaces instructions.

Checklist:

  • [yes] Have you successfully deployed to an AWS account with your changes?
  • [yes] Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maghirardelli maghirardelli requested a review from a team as a code owner July 22, 2021 16:14
@maghirardelli maghirardelli changed the base branch from mainline to develop July 22, 2021 17:04
@maghirardelli maghirardelli changed the title Added details found needed while onboarding docs: Added details found needed while onboarding Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #593 (676c51c) into develop (fada154) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #593   +/-   ##
========================================
  Coverage    49.07%   49.07%           
========================================
  Files          244      244           
  Lines        12543    12543           
  Branches      2016     2015    -1     
========================================
  Hits          6155     6155           
  Misses        5581     5581           
  Partials       807      807           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fada154...676c51c. Read the comment docs.

@@ -12,6 +12,8 @@ To run the E2E tests, you will need the following items:
- Username and password of an admin for the Service Workbench environment
- Username and password of a researcher for the Service Workbench environment
- A project set up for that researcher that can launch EC2 workspaces and Sagemaker workspaces
- Within that project, a study where the researcher is admin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@Bingjiling Bingjiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maghirardelli maghirardelli merged commit d375785 into develop Jul 22, 2021
@maghirardelli maghirardelli deleted the smalldocchange branch July 22, 2021 18:45
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants