Skip to content

Commit

Permalink
Removed tensorboard logging of embedding & output parameters at every…
Browse files Browse the repository at this point in the history
… checkpoint. This used a lot of disk space. (#379)
  • Loading branch information
fhieber authored and tdomhan committed May 4, 2018
1 parent f192892 commit cf05bb2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ Note that Sockeye has checks in place to not translate with an old model that wa

Each version section may have have subsections for: _Added_, _Changed_, _Removed_, _Deprecated_, and _Fixed_.

## [1.18.8]
### Removed
- Removed tensorboard logging of embedding & output parameters at every checkpoint. This used a lot of disk space.

## [1.18.7]
### Added
- Added support for LHUC in RNN models (David Vilar, "Learning Hidden Unit
Expand Down
2 changes: 1 addition & 1 deletion sockeye/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
# express or implied. See the License for the specific language governing
# permissions and limitations under the License.

__version__ = '1.18.7'
__version__ = '1.18.8'
3 changes: 0 additions & 3 deletions sockeye/training.py
Original file line number Diff line number Diff line change
Expand Up @@ -745,9 +745,6 @@ def _update_metrics(self,
tf_metrics.update({"%s_grad" % n: v for n, v in self.state.gradients.items()})
tf_metrics.update(self.model.params)
self.tflogger.log_metrics(metrics=tf_metrics, checkpoint=self.state.checkpoint)
self.tflogger.log_source_embedding(self.model.get_source_embed_params(), self.state.checkpoint)
self.tflogger.log_target_embedding(self.model.get_target_embed_params(), self.state.checkpoint)
self.tflogger.log_output_embedding(self.model.get_output_embed_params(), self.state.checkpoint)

def _cleanup(self, lr_decay_opt_states_reset: str, process_manager: Optional['DecoderProcessManager'] = None):
"""
Expand Down

0 comments on commit cf05bb2

Please sign in to comment.