Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downsized integration tests for faster test runs #415

Merged
merged 2 commits into from
May 26, 2018

Conversation

fhieber
Copy link
Contributor

@fhieber fhieber commented May 26, 2018

Our number of integration tests and their size has grown considerably. For faster test runs I downsized most of them by halving model sizes etc.

On Travis this saves ~10 seconds overall time spent in unit/integration tests.

Pull Request Checklist

  • Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
    until you can check this box.
  • Unit tests pass (pytest)
  • Passed code style checking (./style-check.sh)
  • You have considered writing a test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@mjdenkowski mjdenkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I agree with downsizing integration tests as much as possible since we're only looking at whether the components can interact successfully.

@fhieber fhieber merged commit 530e988 into master May 26, 2018
@fhieber fhieber deleted the downsize_integration_tests branch May 26, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants