Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv: set NoEcho on sensitive params in template.yaml #18

Merged
merged 1 commit into from
Mar 27, 2021

Conversation

nason
Copy link
Contributor

@nason nason commented Oct 15, 2020

Issue #, if available:

N/A

Description of changes:

mask the parameter value to prevent it from being displayed in the console, command line tools, or API

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/parameters-section-structure.html#parameters-section-structure-properties

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@da3mon-01
Copy link
Contributor

@nason Hey, could you fix the Semantic versioning issue of your PR? might be merged quicker then

@heitorlessa heitorlessa changed the title Set NoEcho on sensitive params in template.yaml improv: set NoEcho on sensitive params in template.yaml Nov 4, 2020
@nason
Copy link
Contributor Author

nason commented Nov 11, 2020

Sorry for the delay @da3mon-01 -- I updated the commit

Thanks!

Copy link
Contributor

@joshuachong joshuachong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. Have reviewed and looks ok.

@joshuachong joshuachong merged commit 1667b9e into awslabs:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants