Plateau stopper #334
Merged
Plateau stopper #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseeger
previously approved these changes
Sep 2, 2022
| @@ -118,3 +120,89 @@ def __call__(self, status: TuningStatus) -> bool: | |||
| ) | |||
| return True | |||
| return False | |||
|
|
|||
|
|
|||
| class PlateauStopper(object): | |||
There was a problem hiding this comment.
It would be nice to be able to combine this with another stop criterion (stop once any of them return true).
Could be done in another PR.
mseeger
previously approved these changes
Sep 4, 2022
geoalgo
reviewed
Sep 5, 2022
tst/test_plateau_stopper.py
Outdated
| from tst.util_test import temporary_local_backend | ||
|
|
||
|
|
||
| def test_plateau_scheduler(): |
There was a problem hiding this comment.
This is more of a integration/smoke test. It would be nice to have a unit-test in addition that tests more cases with artificial cases. This can be done by just showing artificial results (updating a tuning status) to the plateau and checking that the right behavior (stop or not stop) is obtained for patience/mode/top values.
It is very easy to have an error sneaking in otherwise (for instance with some combination of mode/patience).
geoalgo
previously approved these changes
Sep 6, 2022
geoalgo
approved these changes
Sep 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#330
Description of changes: Implements a stopping criterion that terminates the HPO process if the metric hasn't improved for N consecutive steps.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.