Refactoring and renaming of BoTorchSearcher and BoTorch #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseeger
commented
Jan 21, 2023
| from botorch.models import SingleTaskGP | ||
| from botorch.fit import fit_gpytorch_model |
There was a problem hiding this comment.
This function is deprecated
| @@ -450,3 +451,84 @@ def _restore_from_state(self, state: dict): | |||
|
|
|||
| def set_random_state(self, random_state: np.random.RandomState): | |||
| self.random_state = random_state | |||
|
|
|||
|
|
|||
| class SearcherWithRandomSeedAndFilterDuplicates(SearcherWithRandomSeed): | |||
There was a problem hiding this comment.
This is code to be introduced in #487, which will be merged before this one here.
mseeger
force-pushed
the
refactor_botorch
branch
from
f26a2c0
to
75820bf
Compare
wesk
reviewed
Jan 23, 2023
| @@ -16,9 +16,11 @@ | |||
|
|
|||
| try: | |||
| from syne_tune.optimizer.schedulers.searchers.botorch.botorch_searcher import ( # noqa: F401 | |||
| BotorchSearcher, | |||
| BoTorchSearcher, | |||
| BotorchSearcher, # deprecated | |||
There was a problem hiding this comment.
Can BotorchSearcher be removed entirely in favor of BoTorchSearcher?
There was a problem hiding this comment.
I see -- looks like you are keeping it for backwards compatibility
There was a problem hiding this comment.
Yes, we can remove it after a while
wesk
previously approved these changes
Jan 23, 2023
mseeger
force-pushed
the
refactor_botorch
branch
from
75820bf
to
5bd86d2
Compare
wesk
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Simplification and renaming of BoTorchSearcher. This PR will be followed by an extension of the developer tutorial, which uses this searcher as example how to wrap external code. The wrapper should therefore be up-2-date with respect to support from base classes.
Also, one deprecated BoTorch function is replaced.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.