Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix ListTrainingJobs throttling for E2E tests #634

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

wesk
Copy link
Collaborator

@wesk wesk commented Apr 20, 2023

Problem:

End-to-end tests are failing with the following error:

An error occurred (ThrottlingException) when calling the ListTrainingJobs operation (reached max retries: 2): Rate exceeded
Error: Process completed with exit code 254.

This is because the aws cli command is calling the API too quickly.

Solution:

  • Call the API more slowly, with an embedded 2-second sleep between paginated calls to avoid throttling.
  • Rewrite script in Python for readability.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (90cef33) 65.13% compared to head (d667f88) 65.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   65.13%   65.14%           
=======================================
  Files         374      374           
  Lines       27155    27155           
=======================================
+ Hits        17688    17690    +2     
+ Misses       9467     9465    -2     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wesk wesk changed the title fix: e2e tests fix: Fix ListLabelingJobs throttling for E2E tests Apr 20, 2023
@wesk wesk changed the title fix: Fix ListLabelingJobs throttling for E2E tests fix: Fix ListTrainingJobs throttling for E2E tests Apr 20, 2023
@wesk wesk marked this pull request as ready for review April 20, 2023 14:16
@wesk wesk requested a review from mseeger April 21, 2023 13:18
@wesk wesk merged commit 489ab94 into main Apr 21, 2023
29 checks passed
@wesk wesk deleted the 2023-04-20-workaround-run-e2e-tests branch April 21, 2023 13:56
@wesk wesk added fix chore and removed fix labels May 2, 2023
@mseeger mseeger added fix and removed chore labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants