-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix unit test #678
chore: fix unit test #678
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
+ Coverage 65.83% 65.92% +0.09%
==========================================
Files 397 398 +1
Lines 27767 27782 +15
==========================================
+ Hits 18280 18315 +35
+ Misses 9487 9467 -20
☔ View full report in Codecov by Sentry. |
@@ -50,27 +51,37 @@ def test_tuner_is_run_the_expected_number_of_times( | |||
"nas201-ImageNet16-120": nas201_mo_benchmark("ImageNet16-120"), | |||
} | |||
|
|||
config_space = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us at least use the correct space for these benchmarks:
hp_cols = ["hp_x0", "hp_x1", "hp_x2", "hp_x3", "hp_x4", "hp_x5"]
config_space = {
node: choice(
["avg_pool_3x3", "nor_conv_3x3", "skip_connect", "nor_conv_1x1", "none"]
)
for node in hp_cols
}
config_space["epochs"] = 200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Problem
Unit test started failing after #672 was merged, which adds an assert about the config space for the MOREA method. The unit test was returning an invalid config space, which failed the assert.
Solution
Have the mock blackbox return a specific config space.
Alternative considered: we can actually remove the
mock_blackbox
entirely, but then the test would run for >1sec.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.