fix: Avoid sphinx 7.0.0, since the readthedocs build fails with that #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
=======================================
Coverage 65.14% 65.14%
=======================================
Files 427 427
Lines 28692 28692
=======================================
Hits 18690 18690
Misses 10002 10002 ☔ View full report in Codecov by Sentry. |
wesk
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Thanks! Will keep an eye on readthedocs/sphinx_rtd_theme#1463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could investigate more, but fact is our docs do not currently build on readthedocs, and downgrading sphinx to <7.0.0 solves that issue. This is what I found:
readthedocs/readthedocs.org#10279
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.