-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automatic streamlining of configuration space #741
Conversation
@@ -57,8 +63,8 @@ | |||
|
|||
|
|||
_config_space = { | |||
NUM_UNITS_1: randint(4, 1024), | |||
NUM_UNITS_2: randint(4, 1024), | |||
NUM_UNITS_1: lograndint(4, 1024), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change, because our own replacement logic maps randint
to lograndint
when upper >= 100 * lower
.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 64.04% 64.22% +0.18%
==========================================
Files 433 435 +2
Lines 28952 29034 +82
==========================================
+ Hits 18542 18648 +106
+ Misses 10410 10386 -24
☔ View full report in Codecov by Sentry. |
|
||
def fit_to_regular_grid(x: np.ndarray) -> Dict[str, float]: | ||
r""" | ||
Computes the least squares fit of :math:`a * j + b` to ``x[j]``, where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is x[j] here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The j-th entry of array x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but what does it corresponds to? A single hyperparameter in the config space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a subroutine. It is called with the sorted values for one numerical choice variable, or with the log of these. The docs of convert_domain
explain that.
This is automating some best practices for choosing domains in
config_space
. Particularly useful for people who come from other tools, like Optuna, where you don't have the finite numerical types we have.Closes #380.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.