Make this module a publishable, installable module and CLI #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeacom
commented
Feb 23, 2023
| @@ -1,11 +1,8 @@ | |||
| import glob | |||
There was a problem hiding this comment.
These are all unused imports.
mbeacom
commented
Feb 23, 2023
| import argparse | ||
| import itertools |
There was a problem hiding this comment.
These are all unused imports.
hanboooli
approved these changes
Mar 27, 2023
|
Thank you @mbeacom! This project has been published to PyPI https://pypi.org/project/tf-policy-validator/ I have created issues for your recommended next steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4
Description of changes: The purpose of this PR is to make the project a full fledged python module that can now be installed via
pipor other python virtual environment/dependency management tools (not just pipenv). This means the project can now be published on pypi for broader distribution. This also adds an entrypoint to allow accessing the CLI via:tf-iam-validatore.g.:pip install . tf-iam-validator -hI intentionally haven't modified the pep-8 noncompliant python styling and merely made the changes needed to run the CLI. This may require changes to the
open()calls against the config file since it's bundled into this repo.Recommended next steps:
blackandisortrufforpylintHappy to provide the canned routines to auto-publish and validate (from other projects I've added them to, like aws-samples/eks-cluster-upgrade
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.