Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging for Parameter Store #194

Closed
stockf opened this issue Oct 19, 2021 · 2 comments · Fixed by #229
Closed

Logging for Parameter Store #194

stockf opened this issue Oct 19, 2021 · 2 comments · Fixed by #229
Assignees
Labels
component: parameter-store Parameter Store integration related issue component: secrets-manager Secrets Manager integration related issue type: bug Something isn't working
Milestone

Comments

@stockf
Copy link

stockf commented Oct 19, 2021

Type: Bug / Help needed

Component:
"Parameter Store"

Describe the bug
I ran the sample for spring-cloud-aws-parameter-store and tried adding debug logging in order to see which parameters should be retrieved from SSM.

The Documentation states that

In order to find out which properties are retrieved from AWS Parameter Store on application startup, turn on DEBUG logging on io.awspring.cloud.paramstore.AwsParamStorePropertySource class.

logging.level.io.awspring.cloud.paramstore.AwsParamStorePropertySource=debug

I added that to application.properties but I can see no debug logs. Can you please explain how to enable debug logging in your sample? Without that debugging will be a nightmare.

Thank you.

Sample
See https://github.com/awspring/spring-cloud-aws/tree/2.3.x/spring-cloud-aws-samples/spring-cloud-aws-parameter-store-sample

@github-actions github-actions bot added type: bug Something isn't working status: waiting-for-triage Team has not yet looked into this issue labels Oct 19, 2021
@ThalysGomes2020
Copy link

Not sure, but might be helpful
we use logback as a logging framework, so I just added this on our logback.xml:

<logger name="io.awspring.cloud.paramstore" level="DEBUG"/>

2021-12-21 19:54:31,880 INFO  logger="io.awspring.cloud.paramstore.AwsParamStorePropertySourceLocator" marker="" message="Loading property from AWS Parameter Store with name: hgfdhgfdhgfd, optional: false" thread="restartedMain" 
2021-12-21 19:54:31,993 DEBUG logger="io.awspring.cloud.paramstore.AwsParamStorePropertySource" marker="" message="Populating property retrieved from AWS Parameter Store: xxx.client_id" thread="restartedMain" 

it might depend on your log framework

@maciejwalkowiak
Copy link
Contributor

Indeed I faced today the same issue. What is stated in docs worked for using Parameter Store with Spring Cloud Bootstrap, but not with spring.config.import. We should fix it, in similar way as it has been done for Vault: spring-cloud/spring-cloud-vault#565

@maciejwalkowiak maciejwalkowiak added component: parameter-store Parameter Store integration related issue component: secrets-manager Secrets Manager integration related issue status: ideal-for-contribution We agree it's nice to have but it is not team priority and removed status: waiting-for-triage Team has not yet looked into this issue status: ideal-for-contribution We agree it's nice to have but it is not team priority labels Feb 5, 2022
@maciejwalkowiak maciejwalkowiak self-assigned this Feb 6, 2022
@maciejwalkowiak maciejwalkowiak added this to the 2.3.4 milestone Feb 6, 2022
maciejwalkowiak added a commit that referenced this issue Feb 6, 2022
... when used with `spring.config.import`.

Fixes #194
maciejwalkowiak added a commit that referenced this issue Feb 6, 2022
... when used with `spring.config.import`.

Fixes #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: parameter-store Parameter Store integration related issue component: secrets-manager Secrets Manager integration related issue type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants