-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add SNS FIFO Topic support #130
Closed
codingtim
wants to merge
3
commits into
awspring:2.3.x
from
codingtim:feature/messaging-sns-message-group-id
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -47,6 +47,16 @@ public class TopicMessageChannel extends AbstractMessageChannel { | |||||
*/ | ||||||
public static final String NOTIFICATION_SUBJECT_HEADER = "NOTIFICATION_SUBJECT_HEADER"; | ||||||
|
||||||
/** | ||||||
* Message group id for SNS message (applies only to FIFO topic). | ||||||
*/ | ||||||
public static final String MESSAGE_GROUP_ID_HEADER = "MessageGroupId"; | ||||||
|
||||||
/** | ||||||
* Message Deduplication id for SNS message. | ||||||
*/ | ||||||
public static final String MESSAGE_DEDUPLICATION_ID_HEADER = "MessageDeduplicationId"; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as before
Suggested change
|
||||||
|
||||||
private final JsonStringEncoder jsonStringEncoder = JsonStringEncoder.getInstance(); | ||||||
|
||||||
private final AmazonSNS amazonSns; | ||||||
|
@@ -71,6 +81,13 @@ protected boolean sendInternal(Message<?> message, long timeout) { | |||||
if (!messageAttributes.isEmpty()) { | ||||||
publishRequest.withMessageAttributes(messageAttributes); | ||||||
} | ||||||
if (message.getHeaders().containsKey(MESSAGE_GROUP_ID_HEADER)) { | ||||||
publishRequest.withMessageGroupId(message.getHeaders().get(MESSAGE_GROUP_ID_HEADER, String.class)); | ||||||
} | ||||||
if (message.getHeaders().containsKey(MESSAGE_DEDUPLICATION_ID_HEADER)) { | ||||||
publishRequest.withMessageDeduplicationId( | ||||||
message.getHeaders().get(MESSAGE_DEDUPLICATION_ID_HEADER, String.class)); | ||||||
} | ||||||
this.amazonSns.publish(publishRequest); | ||||||
|
||||||
return true; | ||||||
|
@@ -82,6 +99,10 @@ private Map<String, MessageAttributeValue> getMessageAttributes(Message<?> messa | |||||
String messageHeaderName = messageHeader.getKey(); | ||||||
Object messageHeaderValue = messageHeader.getValue(); | ||||||
|
||||||
if (isSkipHeader(messageHeaderName)) { | ||||||
continue; | ||||||
} | ||||||
|
||||||
if (MessageHeaders.CONTENT_TYPE.equals(messageHeaderName) && messageHeaderValue != null) { | ||||||
messageAttributes.put(messageHeaderName, getContentTypeMessageAttribute(messageHeaderValue)); | ||||||
} | ||||||
|
@@ -112,6 +133,10 @@ else if (messageHeaderValue instanceof List) { | |||||
return messageAttributes; | ||||||
} | ||||||
|
||||||
private boolean isSkipHeader(String headerName) { | ||||||
return MESSAGE_GROUP_ID_HEADER.equals(headerName) || MESSAGE_DEDUPLICATION_ID_HEADER.equals(headerName); | ||||||
} | ||||||
|
||||||
private MessageAttributeValue getStringArrayMessageAttribute(List<Object> messageHeaderValue) { | ||||||
|
||||||
List<String> stringValues = messageHeaderValue.stream() | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this value be the same as the SQS headers in SqsMessageHeaders.java?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct that this does not follow the naming of SqsMessageHeaders. I followed the AWS header naming. I do not see added value in adding another translation layer which is confusing to users?
I also understand the need for consistency so maintainer can say which is preferred :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be in for keeping consistency with AWS naming, but since SQS has been implemented already like that 4 years ago, lets keep it in sync with SQS implementation.
We can reconsider for 3.0