Add warning in case that the SimpleMessageListenerContainer is used with fifo queue and the AmazonSQSBufferedAsyncClient. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a fifo queue and the AmazonSQSBufferedAsyncClient.
maciejwalkowiak
approved these changes
Mar 7, 2021
...ing/src/main/java/io/awspring/cloud/messaging/listener/AbstractMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
…saging/listener/AbstractMessageListenerContainer.java Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
juho9000
pushed a commit
to juho9000/spring-cloud-aws
that referenced
this pull request
Apr 29, 2021
…ith fifo queue and the AmazonSQSBufferedAsyncClient. (awspring#94) Fixes awspring#81
juho9000
pushed a commit
to juho9000/spring-cloud-aws
that referenced
this pull request
Apr 29, 2021
…ith fifo queue and the AmazonSQSBufferedAsyncClient. (awspring#94) Fixes awspring#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR ads logs a warning if the SimpleMessageListenerContainer is used with a fifo queue and the AmazonSQSBufferedAsyncClient. The AmazonSQSBufferedAsyncClient is not supporting FIFO queues!
💡 Motivation and Context
See #81
💚 How did you test it?
Added a test case
📝 Checklist
🔮 Next steps