New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(regex): check global flag is present #295

Merged

jesus-seijas-sp merged 1 commit into axa-group:master from ericzon:fix/regex-checking

Oct 14, 2019

Collaborator

ericzon commented Oct 12, 2019

Pull Request Template

PR Checklist

I have run npm test locally and all tests are passing.
I have added/updated tests for any new behavior.

PR Description

Passing a regex without 'g' flag to addRegex results in an infinite loop. This checks that and fix the incoming regex.


          fix(regex): check global flag is present

f51f731

coveralls commented Oct 12, 2019

Pull Request Test Coverage Report for Build 1011

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 96.473%

Totals
Change from base Build 258:	0.002%
Covered Lines:	3802
Relevant Lines:	3882

💛 - Coveralls

coveralls commented Oct 12, 2019 •

edited

Loading

Pull Request Test Coverage Report for Build 1011

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 96.473%

Totals
Change from base Build 258:	0.002%
Covered Lines:	7604
Relevant Lines:	7764

💛 - Coveralls

jesus-seijas-sp merged commit b10aad2 into axa-group:master

ericzon mentioned this pull request

entity: verify if regex entered in frontend is correct or not axa-group/nlp.js-app#15

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet