Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Preferences do not open #435

Closed
brummbrum opened this issue Jun 6, 2022 · 5 comments
Closed

System Preferences do not open #435

brummbrum opened this issue Jun 6, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@brummbrum
Copy link

Thanks for taking the time to submit a bug report! Please include the following information:

What operating system are you using?

Raspian Buster

What version of Tartube are you using?

v2.4.065

Installed via pip3. Tried both with root privileges as well as without. Fails with the same type error at the same line 2407 in config.py (see below). As you can see, currently installed without root privileges in the home directory.

What happens when you run Tartube from a terminal window?

Traceback (most recent call last):
File "/home/pi/.local/lib/python3.7/site-packages/tartube/mainapp.py", line 24099, in on_menu_system_preferences
config.SystemPrefWin(self)
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 19254, in init
self.setup()
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 109, in setup
self.setup_tabs()
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 19485, in setup_tabs
self.setup_operations_tab()
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 22511, in setup_operations_tab
self.setup_operations_downloads_tab(self.operations_inner_notebook)
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 22906, in setup_operations_downloads_tab
0, 4, 1, 1,
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 2407, in add_checkbutton
checkbutton.set_active(set_flag)
TypeError: Argument 1 does not allow None as a value

==========================================

PS: First tartube would not update yt-dlp or download anything. Since I was not able to get into the system preferences, I edited settings.json manually: changed "ytdl_update_current" from default to "ytdl_update_pypi_path" and ""ytdl_path" from default to "~/.local/bin/youtube-dl". Now tartube works fine, but it is very inconvenient to change all the detailed settings manually rather than via System Preferences. Thanks!!

@brummbrum brummbrum added the bug Something isn't working label Jun 6, 2022
axcore pushed a commit that referenced this issue Jun 6, 2022
@axcore
Copy link
Owner

axcore commented Jun 6, 2022

Fixed in v2.4.069. You found a bug in which one of the checkbuttons did display the correct internal value. i don't know why it produces Python errors for you but not for me; changes to the Gtk graphics library probably.

You should be able to update using Pip.

@axcore axcore closed this as completed Jun 6, 2022
@brummbrum
Copy link
Author

Thank you for the incredibly speedy response! I upgraded via pip3 to v2.4.069 but it still does not work - still getting the same error:

TypeError: Argument 1 does not allow None as a value

Checking the terminal again I realized that I had overlooked a gdk error right at startup and a few harmless (?) warnings from gio.py (sorry! Full terminal output below):

(tartube:6266): Gdk-CRITICAL **: 09:50:06.444: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed

I figure this may be the root cause for it failing later in config.py. I am on the latest Raspian Buster long term stable release and cannot try an upgrade to Bullseye for a bunch of reasons. Not sure which libs I could try to update, but this seems to run deeper.... any ideas?

Everything else is running totally fine in tartube, only inconvenience is that all setting changes have to be done manually in the json.

===========================================
Here is the complete terminal output:
~ $ ./.local/bin/tartube

playsound is relying on another python subprocess. Please use pip install pygobject if you want playsound to run more efficiently.

(tartube:6266): Gdk-CRITICAL **: 09:50:06.444: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed
/usr/lib/python3/dist-packages/gi/overrides/Gio.py:44: Warning: unable to set property 'strikethrough-set' of type 'gboolean' from value of type 'gchararray'
return Gio.Application.run(self, *args, **kwargs)
/usr/lib/python3/dist-packages/gi/overrides/Gio.py:44: Warning: unable to set property 'underline-set' of type 'gboolean' from value of type 'gchararray'
return Gio.Application.run(self, *args, **kwargs)
/usr/lib/python3/dist-packages/gi/overrides/Gio.py:44: Warning: unable to set property 'weight-set' of type 'gboolean' from value of type 'gchararray'
return Gio.Application.run(self, *args, **kwargs)
/usr/lib/python3/dist-packages/gi/overrides/Gio.py:44: Warning: unable to set property 'style-set' of type 'gboolean' from value of type 'gchararray'
return Gio.Application.run(self, *args, **kwargs)
Traceback (most recent call last):
File "/home/pi/.local/lib/python3.7/site-packages/tartube/mainapp.py", line 24099, in on_menu_system_preferences
config.SystemPrefWin(self)
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 19254, in init
self.setup()
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 109, in setup
self.setup_tabs()
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 19485, in setup_tabs
self.setup_operations_tab()
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 22511, in setup_operations_tab
self.setup_operations_downloads_tab(self.operations_inner_notebook)
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 22962, in setup_operations_downloads_tab
0, 6, grid_width, 1,
File "/home/pi/.local/lib/python3.7/site-packages/tartube/config.py", line 2407, in add_checkbutton
checkbutton.set_active(set_flag)
TypeError: Argument 1 does not allow None as a value

@axcore axcore reopened this Jun 6, 2022
axcore pushed a commit that referenced this issue Jun 7, 2022
@axcore
Copy link
Owner

axcore commented Jun 7, 2022

It's the same category of error, try updating from Pip again.

@brummbrum
Copy link
Author

brummbrum commented Jun 8, 2022

You are faster fixing than I can try :-)
I just upgraded to 2.4.077 (rather than 2.4.072 referenced in this specific fix) and System Preferences works now. Nice!

On initial startup I got a weird message that the database was already in use by another process. Quit tartube. Open again - same message. Decided to ignore and load anyway - et voila everything is working now. Also, upon relaunch of tartube, no weird message regarding the database anymore. Just wanted to let you know about it, does not seem to matter, maybe some odd stuff happening on my Raspberry pi which is running continuously (no reboots since last time testing tartube).

Thanks!

EDIT: Haha, just checked what else you changed and it seems the mechanism/flags used during database load may have had the wrong state and caused the message that I saw. Anyways, it is self healing, i.e. as I said no more message after first occurrence.

@axcore
Copy link
Owner

axcore commented Jun 9, 2022

Great!

@axcore axcore closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants