Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking foreignKey value if exists on the table in related queries #132

Closed
Tracked by #260
ozziest opened this issue Dec 27, 2022 · 1 comment · Fixed by #165
Closed
Tracked by #260

Checking foreignKey value if exists on the table in related queries #132

ozziest opened this issue Dec 27, 2022 · 1 comment · Fixed by #165
Assignees
@ozziest
Labels
blocked It is blocked by something else bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed v1.0.0 It is planned for the V1 version-patch It is just a patch for the current version. It is not a new feature, nor a breaking change.
Projects
v1.0.0

Comments

@ozziest
Copy link
Member

ozziest commented Dec 27, 2022 •
edited

Let's assume that we have a pagination URL like this;

http://localhost:3000/api/users/66/posts

Currently, Axe API doesn't check whether the user id (66) exists on the table. This query will be returned empty anyway. But, it should throw 404.

> Devs should be able send ignoreParentId

Soft-delete should be supported by the model's soft-delete field
@ozziest ozziest created this issue from a note in v1.0.0 (Backlog) Dec 27, 2022
@ozziest ozziest added discussion Something that should be discussed bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers and removed discussion Something that should be discussed labels Dec 27, 2022
@ozziest ozziest moved this from Backlog to Planned in v1.0.0 Dec 31, 2022
@ozziest ozziest mentioned this issue Jan 28, 2023
Closed
26 tasks
@ozziest ozziest self-assigned this Jan 29, 2023
@ozziest ozziest moved this from Planned to Backlog in v1.0.0 Feb 1, 2023
@ozziest ozziest moved this from Planned to Backlog in v1.0.0 Feb 1, 2023
@ozziest ozziest added the version-minor Minor version changes label Feb 19, 2023
@ozziest ozziest moved this from Backlog to Planned in v1.0.0 Mar 28, 2023
@ozziest ozziest removed their assignment Apr 13, 2023
@ozziest ozziest moved this from Planned to Weekly in v1.0.0 Apr 13, 2023
@Arifkarakilic Arifkarakilic mentioned this issue Apr 15, 2023
Merged
@ozziest
Copy link
Member Author

ozziest commented Apr 15, 2023

This issues depends on #168

@ozziest ozziest assigned ozziest and unassigned Arifkarakilic Apr 15, 2023
@ozziest ozziest moved this from Weekly to Backlog in v1.0.0 Apr 15, 2023
@ozziest ozziest moved this from Backlog to Planned in v1.0.0 Apr 15, 2023
@ozziest ozziest added blocked It is blocked by something else version-patch It is just a patch for the current version. It is not a new feature, nor a breaking change. and removed version-minor Minor version changes labels Apr 15, 2023
@ozziest ozziest moved this from Planned to Weekly in v1.0.0 Sep 2, 2023
ozziest added a commit that referenced this issue Oct 29, 2023
@ozziest
Fixed #132
64bbc11
@ozziest ozziest added the v1.0.0 It is planned for the V1 label Oct 29, 2023
@ozziest ozziest moved this from Weekly to In progress in v1.0.0 Oct 29, 2023
@ozziest ozziest moved this from In progress to Pull Request in v1.0.0 Oct 29, 2023
@ozziest ozziest mentioned this issue Oct 29, 2023
Merged
22 tasks
ozziest added a commit that referenced this issue Oct 29, 2023
@ozziest
Fixed #132
79a0424
ozziest added a commit that referenced this issue Dec 1, 2023
@ozziest
Fixed #132
b20685f
v1.0.0 automation moved this from Pull Request to Done! Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozziest ozziest

Labels
blocked It is blocked by something else bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed v1.0.0 It is planned for the V1 version-patch It is just a patch for the current version. It is not a new feature, nor a breaking change.
Projects
No open projects
v1.0.0
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NotFoundError added axe-api/axe-api
2 participants
@ozziest @Arifkarakilic