Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotFoundError added #165

Merged
merged 8 commits into from
May 10, 2023
Merged

NotFoundError added #165

merged 8 commits into from
May 10, 2023

Conversation

Arifkarakilic
Copy link
Contributor

ShowHandler item control status code changed and error class default value bad request made
Close #132

@saracalihan saracalihan mentioned this pull request Apr 15, 2023
Merged
3 tasks
ozziest
ozziest requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@ozziest ozziest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, @Arifkarakilic! 👏 🥳

I requested some changes. Let's keep coding little bit more. 💪

src/Handlers/ShowHandler.ts Outdated Show resolved Hide resolved
src/Handlers/ShowHandler.ts Show resolved Hide resolved
@Arifkarakilic
Copy link
Contributor Author

done

ozziest
ozziest requested changes Apr 22, 2023
View reviewed changes
Copy link
Member

@ozziest ozziest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats! 👏 👏 It looks great.
But we need two more things;

  • Integration tests: we need to check if really got 404
  • Changelog change: we need to increase the version and update changelog file

src/Handlers/ShowHandler.ts Outdated Show resolved Hide resolved
@ozziest ozziest added the pr-request-change We need some changes on the PR label Apr 22, 2023
@ozziest ozziest removed the pr-request-change We need some changes on the PR label May 4, 2023
ozziest
ozziest requested changes May 5, 2023
View reviewed changes
Copy link
Member

@ozziest ozziest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to create a new integration test file. If you execute the following command;

npm run test:mysql8

then you can see the following error;

image

So we should update that test file with the correct HTTP response code.

@ozziest ozziest added the pr-request-change We need some changes on the PR label May 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
13.3% 13.3% Duplication

ozziest
ozziest requested changes May 10, 2023
View reviewed changes
Copy link
Member

@ozziest ozziest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix CHANGELOG. ☺️

@ozziest ozziest changed the base branch from master to develop May 10, 2023 20:06
@ozziest ozziest merged commit 696b579 into develop May 10, 2023
@ozziest ozziest deleted the issue-132-NotFoundError branch May 14, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozziest ozziest ozziest approved these changes

Assignees
No one assigned
Labels
pr-request-change We need some changes on the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checking foreignKey value if exists on the table in related queries
2 participants
@Arifkarakilic @ozziest