Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #374 optimized -p option by throttling the output #387

Closed

Conversation

anindyasen
Copy link

@anindyasen anindyasen commented Oct 4, 2022

#374 With -p option it will only print the percentage when there is a change in value.

@anindyasen anindyasen changed the title Fix for #374 optimized -p option by throttling the output Fix for master#374 optimized -p option by throttling the output Oct 4, 2022
@anindyasen anindyasen changed the title Fix for master#374 optimized -p option by throttling the output Fix for #374 optimized -p option by throttling the output Oct 4, 2022
@anindyasen anindyasen changed the title Fix for #374 optimized -p option by throttling the output Fix for axel-download-accelerator/axel#374 optimized -p option by throttling the output Oct 4, 2022
@anindyasen anindyasen changed the title Fix for axel-download-accelerator/axel#374 optimized -p option by throttling the output Fix for #374 optimized -p option by throttling the output Oct 4, 2022
@anindyasen
Copy link
Author

Hi @ismaell Can you please review this PR?
Thank you.

@ismaell
Copy link
Member

ismaell commented Oct 13, 2022

There's two issues with this patch:

  1. It changes the behaviour of the output, it need s to be newline-terminated and with no prefix like before.
  2. It expects a change in the progress number, which is undesirable, because output constitutes a keep-alive signal as well.

I favour a time-driven throttling mechanism instead.

@ismaell ismaell closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants