feat(evm): include minHeight in VoteConfirmDeposit result event #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack0son
requested review from
cgorenflo,
haiyizxx,
jcs47 and
fish-sammy
as code owners
5 tasks
fish-sammy
reviewed
Jan 21, 2022
x/evm/keeper/msg_server.go
Outdated
| @@ -776,10 +776,13 @@ func (s msgServer) VoteConfirmDeposit(c context.Context, req *types.VoteConfirmD | |||
| return nil, fmt.Errorf("cross-chain sender has no recipient") | |||
| } | |||
|
|
|||
| height, _ := keeper.GetRequiredConfirmationHeight(ctx) | |||
There was a problem hiding this comment.
Don't think you should ignore the error here.
There was a problem hiding this comment.
Thanks - have handled the bool that's returned
cgorenflo
approved these changes
Jan 26, 2022
cgorenflo
previously requested changes
Jan 26, 2022
auto-merge was automatically disabled
January 28, 2022 07:56
Pull Request is not mergeable
fish-sammy
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the microservices to simply fetch the minimum confirmation height for a given
VoteConfirmDepositresult event by reading the event attributes.vald uses the same approach to get this value when responding to a start
ConfirmDepositrequest.Todos
Steps to Test
Expected Behaviour
Other Notes