-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(evm): add query for confirmation height #1243
Conversation
Can't this be done already by querying |
What would the exact query for the ethereum confirmation height look like? Can we include this PR for now so the microservice calling this can use its existing EVM module client? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use the legacy querier. Move this to the newly created grpc query service.
with grpcurl:
AFAIK, grpcurl is also available as a go library. Is it too much of a hassle to incorporate it into the ms and use that instead to retrieve the confirmation height? Also, bear in mind that the "subspace" parameter must be all lower case for the query to work. |
We can fetch the same piece of information using that query instead. But I think there might be an advantage on adding this query to the evm module, in the sense that nobody would need to dig into the code and figure out the names that are used for the subspace and key -- specially if it is a piece of information that is gonna get retrieved frequently, which I think it will be (not just by our own micro-service, but other hypothetical third-party applications). |
Second this. The added query is more robust because it requires less knowledge on the client side. |
Co-authored-by: jcs47 <joao@axelar.network>
Description
Adds a query to get the confirmation height for a given chain to allow the microservices' deposit confirmation process to validate deposits.
Once #1240 is included in the next upgrade, this information can be read from the vote result instead.
Todos
Steps to Test
Expected Behaviour
Other Notes