Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js 13 Web Vitals & React Server Components #120

Closed
wants to merge 58 commits into from
Closed

Conversation

bahlo
Copy link
Member

@bahlo bahlo commented Apr 20, 2023

This drops support for Next.js 12 and adds two hooks:

  • useLogger which returns an Axiom logger
  • useReportWebVitals which reports web vitals automatically

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-axiom-e2e ❌ Failed (Inspect) Jul 6, 2023 0:43am
next-axiom-example ❌ Failed (Inspect) Jul 6, 2023 0:43am

@schehata
Copy link
Collaborator

I've created a webvitals component (not tested yet).

Copy link

@bdsqqq bdsqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢🚢


Bugs, feature requests, and development-related questions should be directed to our GitHub [issue tracker.](https://github.com/axiomhq/next-axiom/issues)

When reporting a bug, please try and provide as much context as possible such as your operating system, NodeJS version and anything else that might be relevant to the bug. For feature requests, please explain what you're trying to do and how the requested feature would help you do that.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ask/encourage minimal repro's for bugs alongside the info?

Copy link

@bdsqqq bdsqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta love up to date ts, very nice

@@ -48,7 +48,7 @@
"ts-jest": "~29.1",
"ts-node": "^10.8.0",
"turbo": "^1.9.9",
"typescript": "^4.6.4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, all the sweeeeeet wins

this avoids a whole host of issues with next-13, see: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-1.html#decoupled-type-checking-between-jsx-elements-and-jsx-tag-types, don't know if we hit them or not but good to know

@schehata
Copy link
Collaborator

schehata commented Jul 6, 2023

Screenshot 2023-07-05 at 7 02 36 PM

This is what the user will see when they update their next12 project to use next-axiom v0.19.0, It's not helpful though.

using pnpm, I was not able to see any peer deps warnings.

@schehata
Copy link
Collaborator

schehata commented Jul 6, 2023

do we still need to send edge reports or does vercel now send reports for all types of routes?

@bahlo
Copy link
Member Author

bahlo commented Jul 24, 2023

Closing for #134

@bahlo bahlo closed this Jul 24, 2023
@niklasp
Copy link

niklasp commented Aug 24, 2023

Screenshot 2023-07-05 at 7 02 36 PM This is what the user will see when they update their next12 project to use next-axiom v0.19.0, It's not helpful though.

using pnpm, I was not able to see any peer deps warnings.

how can i resolve this? seeing it atm

@bahlo
Copy link
Member Author

bahlo commented Aug 24, 2023

@niklasp There is not next-axiom v0.19, the next version is v1.0 and that requires Next.js 13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants