-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js 13 Web Vitals & React Server Components #120
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I've created a webvitals component (not tested yet). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢🚢🚢
|
||
Bugs, feature requests, and development-related questions should be directed to our GitHub [issue tracker.](https://github.com/axiomhq/next-axiom/issues) | ||
|
||
When reporting a bug, please try and provide as much context as possible such as your operating system, NodeJS version and anything else that might be relevant to the bug. For feature requests, please explain what you're trying to do and how the requested feature would help you do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ask/encourage minimal repro's for bugs alongside the info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta love up to date ts, very nice
@@ -48,7 +48,7 @@ | |||
"ts-jest": "~29.1", | |||
"ts-node": "^10.8.0", | |||
"turbo": "^1.9.9", | |||
"typescript": "^4.6.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh, all the sweeeeeet wins
this avoids a whole host of issues with next-13, see: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-1.html#decoupled-type-checking-between-jsx-elements-and-jsx-tag-types, don't know if we hit them or not but good to know
do we still need to send edge reports or does vercel now send reports for all types of routes? |
Closing for #134 |
@niklasp There is not next-axiom v0.19, the next version is v1.0 and that requires Next.js 13. |
This drops support for Next.js 12 and adds two hooks:
useLogger
which returns an Axiom loggeruseReportWebVitals
which reports web vitals automatically