[TypeScript] fix Property 'then' does not exist on type 'AxiosInstance'. #1244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using typescript. Creating an AxiosInstance with axios::create(...) the returned object cannot be used like this:
In javascript this is working perfectly but in typescript you get an error because of wrong typings.
Typings specify that you can do
AxiosInstance.get().then
orAxiosInstance.put().then
but doesn't allow you to do the same as with AxiosStatic and this isn't correct.The error from TypeScript:
Cannot invoke an expression whose type lacks a call signature. Type 'AxiosInstance' has no compatible call signatures.
My fix properly sets function signatures to axiosInstance and then axiosstatic will extend those signatures as expected.
Its sad that almost nobody uses typescript :(
Any comments appreciated