Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use utils.forEach to loop over arguments #127

Merged
merged 1 commit into from Oct 28, 2015

Conversation

@ctimmerm
Copy link
Contributor

commented Oct 13, 2015

Since #91 IE8 support has been broken.
This fixes it by not using utils.forEach to loop over arguments (since in IE8 you can't reliably detect if a variable is an arguments object).

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Oct 27, 2015

@ctimmerm would you mind rebasing your branch from master?

Don't use utils.forEach to loop over arguments
This fixes IE8 support, where we cannot relialably detect an arguments
object.

@ctimmerm ctimmerm force-pushed the ctimmerm:ie8-arguments-foreach branch from a85b34a to 1e2cb9b Oct 28, 2015

@ctimmerm

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2015

@mzabriskie done.

mzabriskie added a commit that referenced this pull request Oct 28, 2015

Merge pull request #127 from ctimmerm/ie8-arguments-foreach
Don't use utils.forEach to loop over arguments

@mzabriskie mzabriskie merged commit ed4a39a into axios:master Oct 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.